Include retry policy in Channel.fromSRA factory #5387
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for nextflow-docs-staging canceled.
|
Signed-off-by: jorgee <[email protected]>
jorgee
force-pushed
the
test_retry_sra_failures
branch
from
6f0313b
to
10c2502
Compare
|
Guess this was closed in favour of #5389? |
|
Yes, due to the issues with the tests, I was testing if they were caused by the branch name. It launched 2 CI pipelines one for the PR and another by a push to a 'test*' branch. This why I closed and rename the branch. |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A retry policy is included in the
Channel.fromSRAfactory following the same approach as used when retriable failures appear in the wave, azure APIs.SraRetryConfigand correspondingSraRetryConfigTestclasses are created to manage the retry policy propertiesSraExplorerclass is modify to include theretryPolicyoption and the management of the retry of the request calls.SraExplorerTestandChannelTestto validate the changes.retryPolicyoption in theChannel.fromSRANote: The
SraExplorerclass was using a deprecated constructorURL()to create a URL. As suggested by the deprecation message, it is changed bynew URI().toURL()